netdev - Re: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Nov 2020 13:37:08 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Lee Jones <lee.jones@...aro.org>, <davem@...emloft.net>,
        <kuba@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Kurt Kanzenbach <kurt@...utronix.de>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document
 am65_cpts_rx_enable()'s 'en' parameter



On 04/11/2020 11:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable'
>   drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable'
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: Kurt Kanzenbach <kurt@...utronix.de>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   drivers/net/ethernet/ti/am65-cpts.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
> index 75056c14b161b..bb2b8e4919feb 100644
> --- a/drivers/net/ethernet/ti/am65-cpts.c
> +++ b/drivers/net/ethernet/ti/am65-cpts.c
> @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp)
>   /**
>    * am65_cpts_rx_enable - enable rx timestamping
>    * @cpts: cpts handle
> - * @skb: packet
> + * @en: enable
>    *
>    * This functions enables rx packets timestamping. The CPTS can timestamp all
>    * rx packets.
> 

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
Best regards,
grygorii