netdev - RE: net: macb: linux-next: null pointer dereference in phylink_major

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Nov 2020 14:15:53 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     "Nicolas.Ferre@...rochip.com" <Nicolas.Ferre@...rochip.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "Claudiu.Beznea@...rochip.com" <Claudiu.Beznea@...rochip.com>,
        "Santiago.Esteban@...rochip.com" <Santiago.Esteban@...rochip.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "harini.katakam@...inx.com" <harini.katakam@...inx.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>
Subject: RE: net: macb: linux-next: null pointer dereference in
 phylink_major_config()

Hi Russell,

It seems apart from changes in driver, we also need check for NULL pcs_config
below or make pcs_config as mandatory method for registering pcs_ops.

456         if (pl->pcs_ops) {
 457                 err = pl->pcs_ops->pcs_config(pl->pcs, pl->cur_link_an_mode,
 458                                               state->interface,
 459                                               state->advertising,
 460                                               !!(pl->link_config.pause &
 461                                                  MLO_PAUSE_AN));
 462                 if (err < 0)
 463                         phylink_err(pl, "pcs_config failed: %pe\n",
 464                                     ERR_PTR(err));
 465                 if (err > 0)
 466                         restart = true;
 467         }

Please suggest.

Regards,
Parshuram Thombare