netdev - Re: [PATCH 06/10] thunderbolt: Create debugfs directory automatically for services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104145807.GP2495@lahna.fi.intel.com>
Date:   Wed, 4 Nov 2020 16:58:07 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Isaac Hazan <isaac.hazan@...el.com>,
        Lukas Wunner <lukas@...ner.de>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 06/10] thunderbolt: Create debugfs directory
 automatically for services

On Wed, Nov 04, 2020 at 03:20:38PM +0100, Greg KH wrote:
> > +/**
> > + * tb_service_debugfs_remove() - Remove service debugfs directory
> > + * @svc: Thunderbolt service pointer
> > + *
> > + * Removes the previously created debugfs directory for @svc.
> > + */
> > +void tb_service_debugfs_remove(struct tb_service *svc)
> > +{
> > +	debugfs_remove(svc->debugfs_dir);
> 
> debugfs_remove_recursive() just to be safe that you really did clean
> everything up?  As you aren't "owning" this directory here, you don't
> know what will get added by some other patch :)

Good point. I'll change it to debugfs_remove_recursive().

> Other than that tiny nit, this series looks good to me, nice work.

Thanks!