netdev - Re: [PATCH 1/2] rsi: Move card interrupt handling to RX thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7e5ad92-de6b-1bd5-18e0-728b8ea454c4@posteo.de>
Date:   Wed, 4 Nov 2020 16:21:46 +0100
From:   Martin Kepplinger <martink@...teo.de>
To:     Marek Vasut <marex@...x.de>, linux-wireless@...r.kernel.org
Cc:     Angus Ainslie <angus@...ea.ca>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Siva Rebbagondla <siva8118@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] rsi: Move card interrupt handling to RX thread

On 03.11.20 19:09, Marek Vasut wrote:
> The interrupt handling of the RS911x is particularly heavy. For each RX
> packet, the card does three SDIO transactions, one to read interrupt
> status register, one to RX buffer length, one to read the RX packet(s).
> This translates to ~330 uS per one cycle of interrupt handler. In case
> there is more incoming traffic, this will be more.
> 
> The drivers/mmc/core/sdio_irq.c has the following comment, quote "Just
> like traditional hard IRQ handlers, we expect SDIO IRQ handlers to be
> quick and to the point, so that the holding of the host lock does not
> cover too much work that doesn't require that lock to be held."
> 
> The RS911x interrupt handler does not fit that. This patch therefore
> changes it such that the entire IRQ handler is moved to the RX thread
> instead, and the interrupt handler only wakes the RX thread.
> 
> This is OK, because the interrupt handler only does things which can
> also be done in the RX thread, that is, it checks for firmware loading
> error(s), it checks buffer status, it checks whether a packet arrived
> and if so, reads out the packet and passes it to network stack.
> 
> Moreover, this change permits removal of a code which allocated an
> skbuff only to get 4-byte-aligned buffer, read up to 8kiB of data
> into the skbuff, queue this skbuff into local private queue, then in
> RX thread, this buffer is dequeued, the data in the skbuff as passed
> to the RSI driver core, and the skbuff is deallocated. All this is
> replaced by directly calling the RSI driver core with local buffer.
> 
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: Angus Ainslie <angus@...ea.ca>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Martin Kepplinger <martink@...teo.de>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
> Cc: Siva Rebbagondla <siva8118@...il.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org
> ---
>   drivers/net/wireless/rsi/rsi_91x_sdio.c     |  6 +--
>   drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 52 ++++++---------------
>   drivers/net/wireless/rsi/rsi_sdio.h         |  8 +---
>   3 files changed, 15 insertions(+), 51 deletions(-)


hi Marek,

I'm running this without problems, so feel free to add

Tested-by: Martin Kepplinger <martin.kepplinger@...i.sm>

to both of your changes. thanks a lot,

                            martin