netdev - Re: [PATCH] can: j1939: add tables for the CAN identifier and its fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a52292a5-3782-21af-adba-686ad2659ff2@pengutronix.de>
Date:   Wed, 4 Nov 2020 17:06:30 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     yegorslists@...glemail.com, linux-can@...r.kernel.org
Cc:     netdev@...r.kernel.org, dev.kurt@...dijck-laurijssen.be
Subject: Re: [PATCH] can: j1939: add tables for the CAN identifier and its
 fields

On 11/4/20 4:57 PM, yegorslists@...glemail.com wrote:
> From: Yegor Yefremov <yegorslists@...glemail.com>
> 
> Use table markup to show the structure of the CAN identifier, PGN, PDU1,
> and PDU2 formats. Also add introductory sentence.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@...glemail.com>
> ---
>  Documentation/networking/j1939.rst | 46 +++++++++++++++++++++++++++---
>  1 file changed, 42 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> index 0a4b73b03b99..19d9878d7194 100644
> --- a/Documentation/networking/j1939.rst
> +++ b/Documentation/networking/j1939.rst
> @@ -69,18 +69,56 @@ J1939 concepts
>  PGN
>  ---
>  
> +The J1939 protocol uses the 29-bit CAN identifier with the following structure:
> +
> +  ============  ==============  ====================
> +  29 bit CAN-ID                                     
> +  --------------------------------------------------
> +  Bit positions within the CAN-ID                   
> +  --------------------------------------------------
> +  28 ... 26     25 ... 8        7 ... 0             
> +  ============  ==============  ====================
> +  Priority      PGN             SA (Source Address) 
> +  ============  ==============  ====================

Here you introduce trailing whitespace. I've removed them while applying the
patch to linux-can/testing

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)