netdev - RE: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR04MB6754884EDFBB94EB16545A1596EF0@AM0PR04MB6754.eurprd04.prod.outlook.com>
Date:   Wed, 4 Nov 2020 16:45:02 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
CC:     Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "james.jurack@...tek.com" <james.jurack@...tek.com>
Subject: RE: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
 skb_cow_head for PTP



>-----Original Message-----
>From: Eric Dumazet <eric.dumazet@...il.com>
>Sent: Tuesday, November 3, 2020 8:16 PM
>To: Vladimir Oltean <olteanv@...il.com>; Claudiu Manoil
><claudiu.manoil@....com>
>Cc: Jakub Kicinski <kuba@...nel.org>; netdev@...r.kernel.org; David S .
>Miller <davem@...emloft.net>; james.jurack@...tek.com
>Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
>skb_cow_head for PTP
>
>
>
>On 11/3/20 6:49 PM, Vladimir Oltean wrote:
>> On Tue, Nov 03, 2020 at 05:41:36PM +0000, Claudiu Manoil wrote:
>>> This is the patch:
>>>
[...]
>>>
>>> are you sure you have it applied?
>>
>> Actually? No, I didn't have it applied... I had thought that net had
>> been already merged into net-next, for some reason :-/
>> Let me run the test for a few more tens of minutes with the patch
>> applied.
>>
>
>I find strange that the local TCP traffic can end up calling
>skb_realloc_headromm() in the old kernels.
>
>Normally TCP reserves a lot of bytes for headers.
>
>#define MAX_TCP_HEADER     L1_CACHE_ALIGN(128 + MAX_HEADER)
>
>It should accommodate the gianfar needs for additional 24 bytes,
>even if LL_MAX_HEADER is 32 in your kernel build perhaps.
>

Hi,
The PTP packets need extra headroom and get reallocated, not TCP packets.
However if TCP streams are sent concurrently with PTP packets, and
skb_realloc_headroom() is used to reallocate PTP packets, we get these crashes.
If skb_cow_head() is used instead there's no crash.