netdev - RE: [PATCH net-next 1/5] r8152: use generic USB macros to define product table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Nov 2020 01:57:10 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Marek Behún <kabel@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH net-next 1/5] r8152: use generic USB macros to define product table

Marek Behún <kabel@...nel.org>
> Sent: Wednesday, November 4, 2020 3:22 AM
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index b1770489aca5..85dda591c838 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -6862,20 +6862,12 @@ static void rtl8152_disconnect(struct
> usb_interface *intf)
>  }
> 
>  #define REALTEK_USB_DEVICE(vend, prod)	\
> -	.match_flags = USB_DEVICE_ID_MATCH_DEVICE | \
> -		       USB_DEVICE_ID_MATCH_INT_CLASS, \
> -	.idVendor = (vend), \
> -	.idProduct = (prod), \
> -	.bInterfaceClass = USB_CLASS_VENDOR_SPEC \
> +	USB_DEVICE_INTERFACE_CLASS(vend, prod, USB_CLASS_VENDOR_SPEC)
> \
>  }, \
>  { \
> -	.match_flags = USB_DEVICE_ID_MATCH_INT_INFO | \
> -		       USB_DEVICE_ID_MATCH_DEVICE, \
> -	.idVendor = (vend), \
> -	.idProduct = (prod), \
> -	.bInterfaceClass = USB_CLASS_COMM, \
> -	.bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> -	.bInterfaceProtocol = USB_CDC_PROTO_NONE
> +	USB_DEVICE_AND_INTERFACE_INFO(vend, prod, USB_CLASS_COMM, \
> +				      USB_CDC_SUBCLASS_ETHERNET, \
> +				      USB_CDC_PROTO_NONE)
> 
>  /* table of devices that work with this driver */
>  static const struct usb_device_id rtl8152_table[] = {

I don't use these, because checkpatch.pl would show error.

	$ scripts/checkpatch.pl --file --terse drivers/net/usb/r8152.c
	ERROR: Macros with complex values should be enclosed in parentheses

Best Regards,
Hayes