netdev - Re: [net 6/9] net/mlx5e: E-Switch, Offload all chain 0 priorities when modify header and forward action is not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104150117.1f139777@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 4 Nov 2020 15:01:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeedm@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        "Jianbo Liu" <jianbol@...lanox.com>, Oz Shlomo <ozsh@...lanox.com>,
        Oz Shlomo <ozsh@...dia.com>, Roi Dayan <roid@...dia.com>
Subject: Re: [net 6/9] net/mlx5e: E-Switch, Offload all chain 0 priorities
 when modify header and forward action is not supported

On Tue, 3 Nov 2020 11:18:27 -0800 Saeed Mahameed wrote:
> From: Jianbo Liu <jianbol@...lanox.com>
> 
> Miss path handling of tc multi chain filters (i.e. filters that are
> defined on chain > 0) requires the hardware to communicate to the
> driver the last chain that was processed. This is possible only when
> the hardware is capable of performing the combination of modify header
> and forward to table actions. Currently, if the hardware is missing
> this capability then the driver only offloads rules that are defined
> on tc chain 0 prio 1. However, this restriction can be relaxed because
> packets that miss from chain 0 are processed through all the
> priorities by tc software.
> 
> Allow the offload of all the supported priorities for chain 0 even
> when the hardware is not capable to perform modify header and goto
> table actions.
> 
> Fixes: 0b3a8b6b5340 ("net/mlx5: E-Switch: Fix using fwd and modify when firmware doesn't support it")
> Signed-off-by: Jianbo Liu <jianbol@...lanox.com>
> Reviewed-by: Oz Shlomo <ozsh@...lanox.com>
> Reviewed-by: Oz Shlomo <ozsh@...dia.com>
> Reviewed-by: Roi Dayan <roid@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

Sounds like a feature TBH.