netdev - Re: [PATCH v2 net-next 1/3] ptp: idt82p33: add adjphase support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104154508.557cc29b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 4 Nov 2020 15:45:08 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     <min.li.xe@...esas.com>
Cc:     <richardcochran@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 1/3] ptp: idt82p33: add adjphase support

On Wed, 4 Nov 2020 18:13:44 -0500 min.li.xe@...esas.com wrote:
> From: Min Li <min.li.xe@...esas.com>
> 
> Add idt82p33_adjphase() to support PHC write phase mode.
> 
> Changes since v1:
> -Fix broken build

One more trivial thing detected by checkpatch:

ERROR: trailing whitespace
#41: FILE: drivers/ptp/ptp_idt82p33.c:138:
+^Ioffset = _OFFSET(regaddr);^I$

Please add Richard's Acked-by tags to the commit messages.

Also are you sure the last patch is okay? Richard suggested it's not
worth the risk AFAIU.