netdev - Re: [PATCH net-next 3/5] r8152: add MCU typed read/write functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104084710.wr3eq4orjspwqvss@skbuf>
Date:   Wed, 4 Nov 2020 10:47:10 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        Hayes Wang <hayeswang@...ltek.com>
Subject: Re: [PATCH net-next 3/5] r8152: add MCU typed read/write functions

On Wed, Nov 04, 2020 at 06:55:24AM +0100, Marek Behún wrote:
> On Tue, 3 Nov 2020 23:47:12 +0200
> Vladimir Oltean <olteanv@...il.com> wrote:
> 
> > On Tue, Nov 03, 2020 at 08:22:24PM +0100, Marek Behún wrote:
> > > Add pla_ and usb_ prefixed versions of ocp_read_* and ocp_write_*
> > > functions. This saves us from always writing MCU_TYPE_PLA/MCU_TYPE_USB
> > > as parameter.
> > > 
> > > Signed-off-by: Marek Behún <kabel@...nel.org>
> > > ---  
> > 
> > You just made it harder for everyone to follow the code through pattern
> > matching. Token concatenation should be banned from the C preprocessor.
> 
> So you aren't complaining about the definition of pla_ and usb_
> functions, just that they are defined via macros?

Yes.