netdev - Re: [PATCH net-next 2/2] net/sched: act_frag: add implict packet fragment support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9e9599f-7d39-2275-0677-930105890850@ucloud.cn>
Date:   Thu, 5 Nov 2020 16:55:31 +0800
From:   wenxu <wenxu@...oud.cn>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net/sched: act_frag: add implict packet
 fragment support.


On 11/5/2020 4:04 PM, Marcelo Ricardo Leitner wrote:
> On Wed, Nov 04, 2020 at 04:56:32PM +0800, wenxu@...oud.cn wrote:
>
>
>
>> +
>>  static void tcf_action_goto_chain_exec(const struct tc_action *a,
>>  				       struct tcf_result *res)
>>  {
>> diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
>> index aba3cd8..e23bc1f 100644
>> --- a/net/sched/act_ct.c
>> +++ b/net/sched/act_ct.c
>> @@ -1541,6 +1541,8 @@ static int __init ct_init_module(void)
>>  	if (err)
>>  		goto err_register;
>>  
>> +	tcf_inc_xmit_hook();
>> +
> Considering the Kconfig is adding the "depends" already, and both can
> be compiled as modules, a request_module() loading act_frag here is
> welcomed. So that the system doesn't end up loading just act_ct (in
> which case, it would panic when outputting a packet).

Yes,  In the v2 move the tcf_xxx_xmit_hook tyoe function to the act_frag.c

So the caller modules like (act_ct) will depend on the act_frag and the act_frag

module will loading before the caller.