netdev - Re: [PATCH v2 net-next 2/2] net/sched: act_frag: add implict packet fragment support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b4ef6031-7a8b-a834-790b-781f6c0fb97e@ucloud.cn>
Date:   Thu, 5 Nov 2020 18:44:36 +0800
From:   wenxu <wenxu@...oud.cn>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] net/sched: act_frag: add implict packet
 fragment support.


On 11/5/2020 4:14 PM, Marcelo Ricardo Leitner wrote:
> On Thu, Nov 05, 2020 at 03:52:27PM +0800, wenxu@...oud.cn wrote:
>
> We cross-posted :)
> I think my comments on the v1 still applies, btw.
>
> ...
>> This patch add support for a xmit hook to mirred, that gets executed before
>> xmiting the packet. Then, when act_ct gets loaded, it configs that hook.
>> The frag xmit hook maybe reused by other modules.
> ...
>> --- a/include/net/act_api.h
>> +++ b/include/net/act_api.h
>> @@ -239,6 +239,29 @@ int tcf_action_check_ctrlact(int action, struct tcf_proto *tp,
>>  			     struct netlink_ext_ack *newchain);
>>  struct tcf_chain *tcf_action_set_ctrlact(struct tc_action *a, int action,
>>  					 struct tcf_chain *newchain);
>> +
>> +#if IS_ENABLED(CONFIG_NET_ACT_FRAG)
>> +int tcf_exec_frag_xmit_hook(struct sk_buff *skb, int (*xmit)(struct sk_buff *skb));
>> +void tcf_set_frag_xmit_hook(void);
>> +void tcf_clear_frag_xmit_hook(void);
>> +bool tcf_frag_xmit_hook_enabled(void);
> Now it's naming the hook after frag action, but it's meant to be
> generic. It got confusing on what is local to act_frag or not due to
> that.

You are right. For more gneric the tcf_xx-xmit_hook should put back to common place and not only used for act_frag.

>