lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Nov 2020 15:35:23 +0100 From: Heiner Kallweit <hkallweit1@...il.com> To: David Laight <David.Laight@...LAB.COM>, Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>, Realtek linux nic maintainers <nic_swsd@...ltek.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net] r8169: disable hw csum for short packets and chip versions with hw padding bug On 05.11.2020 15:20, David Laight wrote: > From: Heiner Kallweit >> Sent: 05 November 2020 13:58 >> >> RTL8125B has same or similar short packet hw padding bug as RTL8168evl. >> The main workaround has been extended accordingly, however we have to >> disable also hw checksumming for short packets on affected new chip >> versions. Change the code in a way that in case of further affected >> chip versions we have to add them in one place only. > > Why not just disable hw checksumming for short packets on > all devices (that use this driver). > Thanks for the hint. Briefly thought about that too but then decided against it as I don't have performance figures. But if everybody is fine with it, then I'd be happy to simplify short packet handling in the described way (in a v2). > It can't make much difference to the performance. > The lack of conditionals may even make it faster. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > Heiner
Powered by blists - more mailing lists