netdev - Re: [PATCH net-next v2 06/19] net: phy: mscc: use phy_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105001008.ze37olgnu5lisyie@skbuf>
Date:   Thu, 5 Nov 2020 02:10:08 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Ioana Ciornei <ciorneiioana@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next v2 06/19] net: phy: mscc: use
 phy_trigger_machine() to notify link change

On Sun, Nov 01, 2020 at 02:51:01PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
> 
> According to the comment describing the phy_mac_interrupt() function, it
> it intended to be used by MAC drivers which have noticed a link change
> thus its use in the mscc PHY driver is improper and, most probably, was
> added just because phy_trigger_machine() was not exported.
> Now that we have acces to trigger the link state machine, use directly
> the phy_trigger_machine() function to notify a link change detected by
> the PHY driver.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---

Tested-by: Vladimir Oltean <olteanv@...il.com>