netdev - RE: [PATCH v3 01/10] Add auxiliary bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB2841C04DA30B0EA299554704DDEE0@DM6PR11MB2841.namprd11.prod.outlook.com>
Date:   Thu, 5 Nov 2020 20:52:13 +0000
From:   "Ertman, David M" <david.m.ertman@...el.com>
To:     Leon Romanovsky <leonro@...dia.com>
CC:     "Williams, Dan J" <dan.j.williams@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Jason Gunthorpe <jgg@...dia.com>,
        Doug Ledford <dledford@...hat.com>,
        Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Fred Oh <fred.oh@...ux.intel.com>,
        Parav Pandit <parav@...lanox.com>,
        "Saleem, Shiraz" <shiraz.saleem@...el.com>,
        "Patil, Kiran" <kiran.patil@...el.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 01/10] Add auxiliary bus support

> -----Original Message-----
> From: Leon Romanovsky <leonro@...dia.com>
> Sent: Thursday, November 5, 2020 11:35 AM
> To: Ertman, David M <david.m.ertman@...el.com>
> Cc: Williams, Dan J <dan.j.williams@...el.com>; alsa-devel@...a-project.org;
> Takashi Iwai <tiwai@...e.de>; Mark Brown <broonie@...nel.org>; linux-
> rdma <linux-rdma@...r.kernel.org>; Jason Gunthorpe <jgg@...dia.com>;
> Doug Ledford <dledford@...hat.com>; Netdev <netdev@...r.kernel.org>;
> David Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> Greg KH <gregkh@...uxfoundation.org>; Ranjani Sridharan
> <ranjani.sridharan@...ux.intel.com>; Pierre-Louis Bossart <pierre-
> louis.bossart@...ux.intel.com>; Fred Oh <fred.oh@...ux.intel.com>; Parav
> Pandit <parav@...lanox.com>; Saleem, Shiraz <shiraz.saleem@...el.com>;
> Patil, Kiran <kiran.patil@...el.com>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>
> Subject: Re: [PATCH v3 01/10] Add auxiliary bus support
> 
> On Thu, Nov 05, 2020 at 07:27:56PM +0000, Ertman, David M wrote:
> > > -----Original Message-----
> > > From: Dan Williams <dan.j.williams@...el.com>
> > > Sent: Thursday, November 5, 2020 1:19 AM
> > > To: Ertman, David M <david.m.ertman@...el.com>
> > > Cc: alsa-devel@...a-project.org; Takashi Iwai <tiwai@...e.de>; Mark
> Brown
> > > <broonie@...nel.org>; linux-rdma <linux-rdma@...r.kernel.org>; Jason
> > > Gunthorpe <jgg@...dia.com>; Doug Ledford <dledford@...hat.com>;
> > > Netdev <netdev@...r.kernel.org>; David Miller
> <davem@...emloft.net>;
> > > Jakub Kicinski <kuba@...nel.org>; Greg KH
> <gregkh@...uxfoundation.org>;
> > > Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>; Pierre-Louis
> Bossart
> > > <pierre-louis.bossart@...ux.intel.com>; Fred Oh
> <fred.oh@...ux.intel.com>;
> > > Parav Pandit <parav@...lanox.com>; Saleem, Shiraz
> > > <shiraz.saleem@...el.com>; Patil, Kiran <kiran.patil@...el.com>; Linux
> > > Kernel Mailing List <linux-kernel@...r.kernel.org>; Leon Romanovsky
> > > <leonro@...dia.com>
> > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support
> > >
> > > Some doc fixups, and minor code feedback. Otherwise looks good to me.
> > >
> > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman
> <david.m.ertman@...el.com>
> > > wrote:
> 
> <...>
> 
> >
> > Again, thanks for the review Dan.  Changes will be in next release (v4) once
> I give
> > stake-holders a little time to respond.
> 
> Everything here can go as a Fixes, the review comments are valuable and
> need
> to be fixed, but they don't change anything dramatically that prevent from
> merging v3.
> 

This works for me - I have the changes saved into an add-on patch that I haven't
squashed into the main patch yet.

> Thanks
> 
> >
> > -DaveE