netdev - Re: [PATCH v3 bpf-next] bpf: make verifier log more relevant by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105145713.10af539e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 5 Nov 2020 14:57:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Jiri Benc <jbenc@...hat.com>, Andrii Nakryiko <andriin@...com>,
        bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next] bpf: make verifier log more relevant by
 default

On Thu, 5 Nov 2020 14:41:12 -0800 Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 1:53 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:  
> > > Should we just drop check_verifier_log() checks?  
> >
> > Drivers only print error messages when something goes wrong, so the
> > messages are high priority. IIUC this change was just supposed to
> > decrease verbosity, right?  
> 
> Seems like check_verifier_log() in test_offline.py is only called for
> successful cases. This patch truncates parts of the verifier log that
> correspond to successfully validated code paths, so that in case if
> verification fails, only relevant parts are left. So for completely
> successful verification the log will be almost empty, with only final
> stats available.

If you're saying the driver message would still be there if
verification or translation failed that's perfectly fine, we 
can definitely adjust the test. But some check that driver 
message reporting is working is needed, don't just remove it.

Sorry, don't have cycles to look closely :(