netdev - Re: [PATCH v3 bpf-next] bpf: make verifier log more relevant by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201106105249.6b0674a8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 6 Nov 2020 10:52:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next] bpf: make verifier log more relevant by
 default

On Fri, 6 Nov 2020 09:24:48 +0100 Jiri Benc wrote:
> On Thu, 5 Nov 2020 14:57:13 -0800, Jakub Kicinski wrote:
> > If you're saying the driver message would still be there if
> > verification or translation failed that's perfectly fine, we 
> > can definitely adjust the test. But some check that driver 
> > message reporting is working is needed, don't just remove it.  
> 
> Should we change the test to fail the verification? Sounds reasonable
> to me.

Yeah, you'd need a new debugfs knob in netdevsim to trigger the failure
from instruction verification, then (to match where message is printed).
And make the output validation a separate case, not just a check in
some random success load.