netdev - Re: [PATCH net-next 00/18] nexthop: Add support for nexthop objects offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201106113159.6c324275@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 6 Nov 2020 11:31:59 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, dsahern@...il.com,
        jiri@...dia.com, mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 00/18] nexthop: Add support for nexthop objects
 offload

On Wed,  4 Nov 2020 15:30:22 +0200 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> This patch set adds support for nexthop objects offload with a dummy
> implementation over netdevsim. mlxsw support will be added later.
> 
> The general idea is very similar to route offload in that notifications
> are sent whenever nexthop objects are changed. A listener can veto the
> change and the error will be communicated to user space with extack.
> 
> To keep listeners as simple as possible, they not only receive
> notifications for the nexthop object that is changed, but also for all
> the other objects affected by this change. For example, when a single
> nexthop is replaced, a replace notification is sent for the single
> nexthop, but also for all the nexthop groups this nexthop is member in.
> This relieves listeners from the need to track such dependencies.
> 
> To simplify things further for listeners, the notification info does not
> contain the raw nexthop data structures (e.g., 'struct nexthop'), but
> less complex data structures into which the raw data structures are
> parsed into.

Applied, thank you!

BTW no need to follow up on my else-after-return comment, 
just something to keep in mind.