netdev - Re: [PATCH iproute2-next] tc: implement support for action terse dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201106123624.75567f35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 6 Nov 2020 12:36:24 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Vlad Buslov <vlad@...lov.dev>, Jamal Hadi Salim <jhs@...atatu.com>,
        netdev@...r.kernel.org, stephen@...workplumber.org,
        davem@...emloft.net, xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH iproute2-next] tc: implement support for action terse
 dump

On Fri, 6 Nov 2020 13:25:19 -0700 David Ahern wrote:
> On 11/6/20 12:16 PM, Vlad Buslov wrote:
> >>>  
> >>
> >> Its unfortunate that the TCA_ prefix ended being used for both filters
> >> and actions. Since we only have a couple of flags maybe it is not too
> >> late to have a prefix TCAA_ ? For existing flags something like a
> >> #define TCAA_FLAG_LARGE_DUMP_ON TCA_FLAG_LARGE_DUMP_ON
> >> in the uapi header will help. Of course that would be a separate
> >> patch which will require conversion code in both the kernel and user
> >> space.  
> > 
> > I can send a followup patch, assuming David is satisfied with proposed
> > change.
> 
> fine with me.

In some ways it helps in some ways it adds to a mix of confusing
acronyms in which TC truly excels.

Are we saying that all new action attrs/defines going forward should 
be prefixed with TCAA, and all new filters with TCFA?

Otherwise, if it's a one off, I'd vote for including _ACT in the name
instead.