netdev - Re: [RFC PATCH bpf-next 3/5] kbuild: Add CONFIG_DEBUG_INFO_BTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbRqmKL3=q+GB=7JvWNxEaOz4CVAcbLQKBxoHF-Gfpv=g@mail.gmail.com>
Date:   Thu, 5 Nov 2020 19:48:47 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [RFC PATCH bpf-next 3/5] kbuild: Add CONFIG_DEBUG_INFO_BTF_MODULES
 option or module BTFs

On Thu, Nov 5, 2020 at 7:13 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Wed, Nov 04, 2020 at 08:51:38PM -0800, Andrii Nakryiko wrote:
> >
> > +config DEBUG_INFO_BTF_MODULES
> > +     bool "Generate BTF for kernel modules"
> > +     def_bool y
> > +     depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF
>
> Does it need to be a new config ?
> Can the build ran pahole if DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF ?

It probably doesn't. If I drop the "bool" line, it will become
non-configurable calculated Kconfig value, convenient to use
everywhere. All the rest will stay exactly the same. It's nice to not
have to do "if defined(DEBUG_INFO_BTF) && defined(MODULES) &&
defined(PAHOLE_HAS_SPLIT_BTF)" checks, but rather a simple "ifdef
CONFIG_DEBUG_INFO_BTF_MODULES". Does that work?