netdev - Re: [PATCH bpf-next v5] bpf: Lift hashtab key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJL574xA3WkdvQa1N-rk81OToTDNbkBVM_n1VR1ZqQCSg@mail.gmail.com>
Date:   Thu, 5 Nov 2020 20:11:33 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Florian Lehner <dev@...-flo.net>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        john fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH bpf-next v5] bpf: Lift hashtab key_size limit

On Thu, Oct 29, 2020 at 1:38 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Thu, Oct 29, 2020 at 1:16 PM Florian Lehner <dev@...-flo.net> wrote:
> >
> > Currently key_size of hashtab is limited to MAX_BPF_STACK.
> > As the key of hashtab can also be a value from a per cpu map it can be
> > larger than MAX_BPF_STACK.
> >
> > The use-case for this patch originates to implement allow/disallow
> > lists for files and file paths. The maximum length of file paths is
> > defined by PATH_MAX with 4096 chars including nul.
> > This limit exceeds MAX_BPF_STACK.
> >
> > Changelog:
> >
> > v5:
> >  - Fix cast overflow
> >
> > v4:
> >  - Utilize BPF skeleton in tests
> >  - Rebase
> >
> > v3:
> >  - Rebase
> >
> > v2:
> >  - Add a test for bpf side
> >
> > Signed-off-by: Florian Lehner <dev@...-flo.net>
> > Acked-by: John Fastabend <john.fastabend@...il.com>
> > ---
>
> LGTM.
> Acked-by: Andrii Nakryiko <andrii@...nel.org>

Applied.
Sorry for the delay. The patch got lost in patchwork.