netdev - Re: [PATCH v2 net] r8169: disable hw csum for short packets on all chip versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201107121653.650f333e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 7 Nov 2020 12:16:53 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net] r8169: disable hw csum for short packets on all
 chip versions

On Thu, 5 Nov 2020 18:14:47 +0100 Heiner Kallweit wrote:
> RTL8125B has same or similar short packet hw padding bug as RTL8168evl.
> The main workaround has been extended accordingly, however we have to
> disable also hw checksumming for short packets on affected new chip
> versions. Instead of checking for an affected chip version let's
> simply disable hw checksumming for short packets in general.
> 
> v2:
> - remove the version checks and disable short packet hw csum in general
> - reflect this in commit title and message
> 
> Fixes: 0439297be951 ("r8169: add support for RTL8125B")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks!