netdev - Re: [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201107113248.A4EBEC433FE@smtp.codeaurora.org>
Date:   Sat,  7 Nov 2020 11:32:48 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, Marek Vasut <marex@...x.de>,
        Angus Ainslie <angus@...ea.ca>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Martin Kepplinger <martink@...teo.de>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Siva Rebbagondla <siva8118@...il.com>,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP

Marek Vasut <marex@...x.de> wrote:

> In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode,
> the association fails. The former is using wpa_supplicant during association,
> the later is set up using hostapd:
> 
> iwl$ cat hostapd.conf
> interface=wlp1s0
> ssid=test
> country_code=DE
> hw_mode=g
> channel=1
> wpa=2
> wpa_passphrase=test
> wpa_key_mgmt=WPA-PSK
> iwl$ hostapd -d hostapd.conf
> 
> rsi$ wpa_supplicant -i wlan0 -c <(wpa_passphrase test test)
> 
> The problem is that the TX EAPOL data descriptor RSI_DESC_REQUIRE_CFM_TO_HOST
> flag and extended descriptor EAPOL4_CONFIRM frame type are not set in case the
> AP is iwlwifi, because in that case the TX EAPOL packet is 2 bytes shorter.
> 
> The downstream vendor driver has this change in place already [1], however
> there is no explanation for it, neither is there any commit history from which
> such explanation could be obtained.
> 
> [1] https://github.com/SiliconLabs/RS911X-nLink-OSD/blob/master/rsi/rsi_91x_hal.c#L238
> 
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: Angus Ainslie <angus@...ea.ca>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Martin Kepplinger <martink@...teo.de>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
> Cc: Siva Rebbagondla <siva8118@...il.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org

Patch applied to wireless-drivers-next.git, thanks.

65277100caa2 rsi: Fix TX EAPOL packet handling against iwlwifi AP

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20201015111616.429220-1-marex@denx.de/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches