netdev - Re: [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201109164154.GA211123@kozik-lap>
Date:   Mon, 9 Nov 2020 17:41:54 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com,
        madalin.bucur@....com, davem@...emloft.net, kuba@...nel.org,
        mperttunen@...dia.com, tomeu.vizoso@...labora.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        netdev@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH V2] memory: tegra: add missing put_devcie() call in error
 path of tegra_emc_probe()

On Mon, Nov 09, 2020 at 09:28:47PM +0800, Yu Kuai wrote:
> The reference to device obtained with of_find_device_by_node() should
> be dropped. Thus add jump target to fix the exception handling for this
> function implementation.

You still need to correct the typo devcie->device in subject, as in v1.

> 
> Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>  drivers/memory/tegra/tegra124-emc.c           | 21 +++++++++++++------
>  .../net/ethernet/freescale/fman/fman_port.c   |  3 +--

Changes in net are not related, please split... although actually I
think the issue is already fixed by 1f1997eb44b1 ("memory: tegra: Add
and use devm_tegra_memory_controller_get()").

Best regards,
Krzysztof