netdev - RE: [PATCH bpf-next] bpf: selftest: Use static globals in tcp_hdr_options and btf_skc_cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fa8e81395e0f_2056c20834@john-XPS-13-9370.notmuch>
Date:   Sun, 08 Nov 2020 22:56:19 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com,
        netdev@...r.kernel.org
Subject: RE: [PATCH bpf-next] bpf: selftest: Use static globals in
 tcp_hdr_options and btf_skc_cls_ingress

Martin KaFai Lau wrote:
> Some globals in the tcp_hdr_options test and btf_skc_cls_ingress test
> are not using static scope.  This patch fixes it.
> 
> Targeting bpf-next branch as an improvement since it currently does not
> break the build.
> 
> Fixes: ad2f8eb0095e ("bpf: selftests: Tcp header options")
> Fixes: 9a856cae2217 ("bpf: selftest: Add test_btf_skc_cls_ingress")
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---
>  .../selftests/bpf/prog_tests/btf_skc_cls_ingress.c   |  2 +-
>  .../selftests/bpf/prog_tests/tcp_hdr_options.c       | 12 ++++++------
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 

Acked-by: John Fastabend <john.fastabend@...il.com>