netdev - Re: [MPTCP] [PATCH net] mptcp: provide rmem[0] limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201109173632.21c7045b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 9 Nov 2020 17:36:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Matthieu Baerts <matthieu.baerts@...sares.net>
Cc:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>, mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net] mptcp: provide rmem[0] limit

On Mon, 9 Nov 2020 18:20:50 +0100 Matthieu Baerts wrote:
> On 08/11/2020 19:49, Paolo Abeni wrote:
> > The mptcp proto struct currently does not provide the
> > required limit for forward memory scheduling. Under
> > pressure sk_rmem_schedule() will unconditionally try
> > to use such field and will oops.
> > 
> > Address the issue inheriting the tcp limit, as we already
> > do for the wmem one.
> > 
> > Fixes: ("mptcp: add missing memory scheduling in the rx path")
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>  
> 
> Good catch, thank you for this patch!
> 
> Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Fixed up the tag and applied, thanks!