netdev - Re: [PATCH v5 8/8] can-dev: add len8_dlc support for various CAN USB adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6fc6c4e-a03f-4f58-1bb6-2bfb830ebebb@hartkopp.net>
Date:   Tue, 10 Nov 2020 11:18:42 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Marc Kleine-Budde <mkl@...gutronix.de>, linux-can@...r.kernel.org,
        mailhol.vincent@...adoo.fr
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v5 8/8] can-dev: add len8_dlc support for various CAN USB
 adapters

On 10.11.20 08:46, Marc Kleine-Budde wrote:
> On 11/10/20 7:55 AM, Oliver Hartkopp wrote:

>> I would suggest something like
>>
>> u8 can_get_cc_len(const u32 ctrlmode, struct can_frame *cf, u8 dlc)
>>
>> that still returns the 'len' element, so that we can replace
>> can_cc_dlc2len() with can_get_cc_len() for CAN drivers that add support
>> for len8_dlc.
> 
> The regex to replace can_cc_dlc2len() with can_get_cc_len() might be simpler,
> but passing the cf by reference _and_ assigning the return value to a member of
> cf looks strange.

This might be a "make the patch looking good" thing too :-D

The code is now implemented even simpler and easy to follow when we 
migrate the other CAN drivers too.

But take a look on yourself. v6 is sent out.

Thanks,
Oliver