netdev - Re: [PATCH v6 net-next 0/3] net/sched: fix over mtu packet of defrag in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 20:23:27 +0200
From:   Vlad Buslov <vladbu@...dia.com>
To:     <wenxu@...oud.cn>
CC:     <kuba@...nel.org>, <marcelo.leitner@...il.com>,
        <dcaratti@...hat.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v6 net-next 0/3] net/sched: fix over mtu packet of defrag in


On Tue 10 Nov 2020 at 08:28, wenxu@...oud.cn wrote:
> From: wenxu <wenxu@...oud.cn>
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mirred to a device which maybe lead the reassembly big packet over the mtu
> of target device.
>
> The first patch fix miss init the qdisc_skb_cb->mru
> The send one refactor the hanle of xmit in act_mirred and prepare for the
> third one
> The last one add implict packet fragment support to fix the over mtu for
> defrag in act_ct.
>
> wenxu (3):
>   net/sched: fix miss init the mru in qdisc_skb_cb
>   net/sched: act_mirred: refactor the handle of xmit
>   net/sched: act_frag: add implict packet fragment support.
>
>  include/net/act_api.h     |  16 +++++
>  include/net/sch_generic.h |   5 --
>  net/core/dev.c            |   2 +
>  net/sched/Kconfig         |  13 ++++
>  net/sched/Makefile        |   1 +
>  net/sched/act_api.c       |  47 +++++++++++++
>  net/sched/act_ct.c        |   7 ++
>  net/sched/act_frag.c      | 164 ++++++++++++++++++++++++++++++++++++++++++++++
>  net/sched/act_mirred.c    |  21 ++++--
>  9 files changed, 265 insertions(+), 11 deletions(-)
>  create mode 100644 net/sched/act_frag.c

Hi,

I ran our CT tests with this series and kernel debug configs enabled
without any issue.

Tested-by: Vlad Buslov <vladbu@...dia.com>