[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 17:24:41 +0800
From: Wang Qing <wangqing@...o.com>
To: "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Grygorii Strashko <grygorii.strashko@...com>,
Samuel Zou <zou_wei@...wei.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Murali Karicheri <m-karicheri2@...com>,
Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: richardcochran@...il.com, Wang Qing <wangqing@...o.com>
Subject: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR
We always have to update the value of ret, otherwise the error value
may be the previous one. And ptp_clock_register() never return NULL
when PTP_1588_CLOCK enable.
Signed-off-by: Wang Qing <wangqing@...o.com>
---
drivers/net/ethernet/ti/am65-cpts.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
index 75056c1..b319d45
--- a/drivers/net/ethernet/ti/am65-cpts.c
+++ b/drivers/net/ethernet/ti/am65-cpts.c
@@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
if (IS_ERR_OR_NULL(cpts->ptp_clock)) {
dev_err(dev, "Failed to register ptp clk %ld\n",
PTR_ERR(cpts->ptp_clock));
- if (!cpts->ptp_clock)
- ret = -ENODEV;
+ ret = PTR_ERR(cpts->ptp_clock);
goto refclk_disable;
}
cpts->phc_index = ptp_clock_index(cpts->ptp_clock);
--
2.7.4
Powered by blists - more mailing lists