[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 11:07:30 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: xiakaixu1987@...il.com, ast@...nel.org, kafai@...com,
songliubraving@...com, yhs@...com, andrii@...nel.org,
john.fastabend@...il.com, kpsingh@...omium.org
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
linux-kernel@...r.kernel.org, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in
check_pseudo_btf_id
On 11/11/20 6:03 AM, xiakaixu1987@...il.com wrote:
> From: Kaixu Xia <kaixuxia@...cent.com>
>
> The unsigned variable datasec_id is assigned a return value from the call
> to check_pseudo_btf_id(), which may return negative error code.
>
> Fixes coccicheck warning:
>
> ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0
>
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
Looks good, applied & also added Fixes tags, thanks!
Powered by blists - more mailing lists