netdev - Re: [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 14:14:20 +0100
From:   "Tobias Waldekranz" <tobias@...dekranz.com>
To:     "Florian Fainelli" <f.fainelli@...il.com>, <davem@...emloft.net>,
        <kuba@...nel.org>
Cc:     <andrew@...n.ch>, <vivien.didelot@...il.com>, <olteanv@...il.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA
 taggers

On Tue Nov 10, 2020 at 8:41 PM CET, Florian Fainelli wrote:
>
>
> On 11/10/2020 1:13 AM, Tobias Waldekranz wrote:
> > Ethertype DSA encodes exactly the same information in the DSA tag as
> > the non-ethertype variety. So refactor out the common parts and reuse
> > them for both protocols.
> > 
> > This is ensures tag parsing and generation as always consistent across
> > all mv88e6xxx chips.
>
> s/as/is/?

ACK

> This looks good to me! This made me remember that we do not really
> interface with devlink traps today in DSA, but we may be able to.

Yeah maybe. I've tried to read up on it as I would like to be able to
control things like DHCP snooping. I have not really been able to wrap
my head around it though.

Using DHCP as an example: that sorts into the "control" type, as
specified in Documentation/networking/devlink/devlink-trap.rst. But
changing the trap action is not allowed. And even if it was allowed,
how do these settings interact with an offloaded tc rule along the
lines of "tc filter add [handwavy wizardry] [match dhcp] action trap"?