netdev - RE: [PATCH net-next] net: phy: aquantia: do not return an error on clearing pending IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 16:44:52 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Ioana Ciornei <ciorneiioana@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Ioana Ciornei <ioana.ciornei@....com>
Subject: RE: [PATCH net-next] net: phy: aquantia: do not return an error on
 clearing pending IRQs

> -----Original Message-----
> From: Ioana Ciornei <ciorneiioana@...il.com>
> Sent: Monday, November 9, 2020 17:46
> To: kuba@...nel.org; netdev@...r.kernel.org
> Cc: Ioana Ciornei <ioana.ciornei@....com>
> Subject: [PATCH net-next] net: phy: aquantia: do not return an error on
> clearing pending IRQs
> 
> From: Ioana Ciornei <ioana.ciornei@....com>
> 
> The referenced commit added in .config_intr() the part of code which upon
> configuration of the IRQ state it also clears up any pending IRQ. If
> there were actually pending IRQs, a read on the IRQ status register will
> return something non zero. This should not result in the callback
> returning an error.
> 
> Fix this by returning an error only when the result of the
> phy_read_mmd() is negative.
> 
> Fixes: e11ef96d44f1 ("net: phy: aquantia: remove the use of
> .ack_interrupt()")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

I ran into this issue recently. Thanks for the fix.

Tested-by: Camelia Groza <camelia.groza@....com>