netdev - Re: [PATCH V3 net] net/ethernet: Fix error return when ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 17:10:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Wang Qing <wangqing@...o.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Samuel Zou <zou_wei@...wei.com>,
        Murali Karicheri <m-karicheri2@...com>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Kurt Kanzenbach <kurt@...utronix.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 net] net/ethernet: Fix error return when ptp_clock is
 ERROR

On Mon,  9 Nov 2020 10:17:52 +0800 Wang Qing wrote:
> We always have to update the value of ret, otherwise the error value
>  may be the previous one. And ptp_clock_register() never return NULL
>  when PTP_1588_CLOCK enable.
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>

Please add a Fixes tag as I requested in a reply to v2.

Please CC Richard on the next version, since he gave you feedback, 
and he's the PTP maintainer.