[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 19:12:22 +0200
From: Kalle Valo <kvalo@...eaurora.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
David Miller <davem@...emloft.net>,
Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
Doug Ledford <dledford@...hat.com>,
Jason Gunthorpe <jgg@...pe.ca>,
Bjørn Mork <bjorn@...k.no>,
Igor Mitsyanko <imitsyanko@...ntenna.com>,
Sergey Matyukevich <geomatsi@...il.com>,
Oliver Neukum <oneukum@...e.com>,
Peter Korsgaard <jacmet@...site.dk>,
Steve Glendinning <steve.glendinning@...well.net>,
Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
Jussi Kivilinna <jussi.kivilinna@....fi>,
"netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
linux-rdma@...r.kernel.org,
Linux USB Mailing List <linux-usb@...r.kernel.org>,
linux-wireless <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH net-next 3/5] qtnfmac: switch to core handling of rx/tx byte/packet counters
Heiner Kallweit <hkallweit1@...il.com> writes:
> Use netdev->tstats instead of a member of qtnf_vif for storing a pointer
> to the per-cpu counters. This allows us to use core functionality for
> statistics handling.
> The driver sets netdev->needs_free_netdev, therefore freeing the per-cpu
> counters at the right point in time is a little bit tricky. Best option
> seems to be to use the ndo_init/ndo_uninit callbacks.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> drivers/net/wireless/quantenna/qtnfmac/core.c | 78 ++++---------------
> drivers/net/wireless/quantenna/qtnfmac/core.h | 4 -
> .../quantenna/qtnfmac/pcie/pearl_pcie.c | 4 +-
> .../quantenna/qtnfmac/pcie/topaz_pcie.c | 4 +-
> 4 files changed, 20 insertions(+), 70 deletions(-)
Jakub, feel free to take this to net-next:
Acked-by: Kalle Valo <kvalo@...eaurora.org>
But I can also take this to wireless-drivers-next, whichever you prefer.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists