netdev - Re: [PATCH v2] can: flexcan: fix reference count leak in flexcan ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 23:16:51 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Zhang Qilong <zhangqilong3@...wei.com>, wg@...ndegger.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] can: flexcan: fix reference count leak in flexcan ops

On 11/8/20 9:30 AM, Zhang Qilong wrote:
> pm_runtime_get_sync() will increment pm usage at first and it
> will resume the device later. If runtime of the device has
> error or device is in inaccessible state(or other error state),
> resume operation will fail. If we do not call put operation to
> decrease the reference, it will result in reference leak in
> the two function(flexcan_get_berr_counter and flexcan_open).
> Moreover, this device cannot enter the idle state and always
> stay busy or other non-idle state later. So we should fix it
> through adding pm_runtime_put_noidle.
> 
> Fixes: ca10989632d88 ("can: flexcan: implement can Runtime PM")
> Signed-off-by: Zhang Qilong <zhangqilong3@...wei.com>
> ---
> Changelog:
> v2
> - removed empty lines between tags.
> ---

Applied to linux-can/testing.

Tnx,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)