netdev - Re: [PATCH net-next v4 10/15] net/smc: Introduce SMCR get link command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 14:34:59 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Karsten Graul <kgraul@...ux.ibm.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, hca@...ux.ibm.com, raspl@...ux.ibm.com
Subject: Re: [PATCH net-next v4 10/15] net/smc: Introduce SMCR get link
 command

On Mon,  9 Nov 2020 16:18:09 +0100 Karsten Graul wrote:
> @@ -129,6 +131,12 @@ struct smc_diag_linkinfo {
>  	__u8 ibport;			/* RDMA device port number */
>  	__u8 gid[40];			/* local GID */
>  	__u8 peer_gid[40];		/* peer GID */
> +	/* Fields above used by legacy v1 code */
> +	__u32 conn_cnt;
> +	__u8 netdev[IFNAMSIZ];		/* ethernet device name */

Why report the name? Interfaces are generally identified by ifindex.

> +	__u8 link_uid[4];		/* unique link id */
> +	__u8 peer_link_uid[4];		/* unique peer link id */
> +	__u32 link_state;		/* link state */
>  };