lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 10 Nov 2020 16:16:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     wenxu@...oud.cn
Cc:     marcelo.leitner@...il.com, dcaratti@...hat.com, vladbu@...dia.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v6 net-next 3/3] net/sched: act_frag: add implict packet
 fragment support.

On Tue, 10 Nov 2020 14:28:06 +0800 wenxu@...oud.cn wrote:
> +static int (*tcf_xmit_hook)(struct sk_buff *skb,
> +			    int (*xmit)(struct sk_buff *skb));

missing the rcu annotation on this

net/sched/act_api.c:35:17: error: incompatible types in comparison expression (different address spaces):
net/sched/act_api.c:35:17:    int ( [noderef] __rcu * )( ... )
net/sched/act_api.c:35:17:    int ( * )( ... )
net/sched/act_api.c:52:17: error: incompatible types in comparison expression (different address spaces):
net/sched/act_api.c:52:17:    int ( [noderef] __rcu * )( ... )
net/sched/act_api.c:52:17:    int ( * )( ... )
net/sched/act_api.c:64:21: error: incompatible types in comparison expression (different address spaces):
net/sched/act_api.c:64:21:    int ( [noderef] __rcu * )( ... )
net/sched/act_api.c:64:21:    int ( * )( ... )

Powered by blists - more mailing lists