netdev - RE: [PATCH net] devlink: Avoid overwriting port attributes of registered port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 03:31:41 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Jiri Pirko <jiri@...dia.com>
Subject: RE: [PATCH net] devlink: Avoid overwriting port attributes of
 registered port

DKIM-Signature: v. a.a-sha256; c.laxed/relaxed; d.idia.com; s.;
	t.05065498; bh.xoWmG7MF25LGw0cL+jslLJ7JSapdTD2W6BQgKGG2w	h
C-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
	 CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
	 In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
	 X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
	 x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
	 x-ms-traffictypediagnostic:x-ms-exchange-transport-forked:
	 x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers:
	 x-ms-exchange-senderadcheck:x-microsoft-antispam:
	 x-microsoft-antispam-message-info:x-forefront-antispam-report:
	 x-ms-exchange-antispam-messagedata:Content-Type:
	 Content-Transfer-Encoding:MIME-Version:
	 X-MS-Exchange-CrossTenant-AuthAs:
	 X-MS-Exchange-CrossTenant-AuthSource:
	 X-MS-Exchange-CrossTenant-Network-Message-Id:
	 X-MS-Exchange-CrossTenant-originalarrivaltime:
	 X-MS-Exchange-CrossTenant-fromentityheader:
	 X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
	 X-MS-Exchange-CrossTenant-userprincipalname:
	 X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
	be8E3mbS/AR9xp4+97cFD/3eP2NGTk6UTiE8zDXnzKWYm7J6w2MBlgXk2qQlw5qv
	 wmL8tm3nRyjDCYgNx/yl1/djqUoZZE2mUpqQnoT7oPeqdRMAgIUDkXhJ5BG6xapjO9
	 hoFAWMaX6KslMJPz+BD0gn1YylPvB3qOqBpbNfq1+cNSA05mIC2pgFn+v6UEJOaWQy
	 1t2RXZgdu52yuCz5qjbGDeo0vc2hzWeT6/M0NHfaF9Ae9p9cezKOtrVuCDTF+2G4gN
	 jPPuoOhcZyUvRUzq8c2W9AKmHh+J8vXS54YaMAUka8Wg4kW9zhySI/2/wKKy8aLnJu
	 zUdeeVmFvi5JQ

> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, November 11, 2020 3:37 AM
> 
> On Tue, 10 Nov 2020 20:52:58 +0200 Parav Pandit wrote:
> > Cited commit in fixes tag overwrites the port attributes for the
> > registered port.
> 
> Seems like you forgot the fixes tag you're referring to.
>
Oops. Yes. while removing internal gerrit Change-ID, I accidently removed Fixes line too.
Resending with Fixes tag.
 
> > Avoid such error by checking registered flag before setting attributes.
> >
> > Signed-off-by: Parav Pandit <parav@...dia.com>
> > Reviewed-by: Jiri Pirko <jiri@...dia.com>