netdev - Re: [PATCH] net/ncsi: Fix re-registering ncsi device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201111165716.760829aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 11 Nov 2020 16:57:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joel Stanley <joel@....id.au>
Cc:     Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        "David S . Miller" <davem@...emloft.net>,
        Andrew Jeffery <andrew@...id.au>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/ncsi: Fix re-registering ncsi device

On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote:
> If a user unbinds and re-binds a ncsi aware driver, the kernel will
> attempt to register the netlink interface at runtime. The structure is
> marked __ro_after_init so this fails at this point.

netlink family should be registered at module init and unregistered at
unload. That's a better fix IMO.