netdev - Re: [PATCH net RESEND] devlink: Avoid overwriting port attributes of registered port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112080952.6c156138@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 08:09:52 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Parav Pandit <parav@...dia.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net RESEND] devlink: Avoid overwriting port attributes
 of registered port

On Wed, 11 Nov 2020 05:47:44 +0200 Parav Pandit wrote:
> Cited commit in fixes tag overwrites the port attributes for the
> registered port.
> 
> Avoid such error by checking registered flag before setting attributes.
> 
> Fixes: 71ad8d55f8e5 ("devlink: Replace devlink_port_attrs_set parameters with a struct")
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Applied, thanks!