netdev - Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-11-10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112120107.4d43108b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 12:01:07 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        netdev@...r.kernel.org, sassmann@...hat.com
Subject: Re: [net 0/4][pull request] Intel Wired LAN Driver Updates
 2020-11-10

On Thu, 12 Nov 2020 11:55:24 -0800 Vinicius Costa Gomes wrote:
> Jakub Kicinski <kuba@...nel.org> writes:
> >
> > Pulled, thanks!
> >
> > Please double check the use of the spin lock in patch 3. Stats are
> > updated in an atomic context when read from /proc, you probably need 
> > to convert that spin lock to _bh.  
> 
> I just did some tests with lockdep enabled, reading from /proc/net/dev
> in a loop, and everything seems fine. Am I missing something?

Indeed /proc only takes the RCU lock so you should be fine, thanks
for checking.