netdev - Re: [PATCH] IPv4: RTM_GETROUTE: Add RTA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112142706.63a1816b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 14:27:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oliver Herms <oliver.peter.herms@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] IPv4: RTM_GETROUTE: Add RTA_ENCAP to result

On Thu, 12 Nov 2020 09:10:08 +0100 Oliver Herms wrote:
> This patch adds an IPv4 routes encapsulation attribute
> to the result of netlink RTM_GETROUTE requests
> (e.g. ip route get 192.0.2.1).
> 
> Signed-off-by: Oliver Herms <oliver.peter.herms@...il.com>
> ---
>  net/ipv4/route.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index dc2a399cd9f4..b4d3384697cb 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -2872,6 +2872,9 @@ static int rt_fill_info(struct net *net, __be32 dst, __be32 src,
>  	if (rt->dst.dev &&
>  	    nla_put_u32(skb, RTA_OIF, rt->dst.dev->ifindex))
>  		goto nla_put_failure;
> +	if (rt->dst.lwtstate && lwtunnel_fill_encap(skb, rt->dst.lwtstate,
> +		RTA_ENCAP, RTA_ENCAP_TYPE) < 0)
> +		goto nla_put_failure;

Please fix this checkpatch warning:

CHECK: Alignment should match open parenthesis
#25: FILE: net/ipv4/route.c:2876:
+	if (rt->dst.lwtstate && lwtunnel_fill_encap(skb, rt->dst.lwtstate,
+		RTA_ENCAP, RTA_ENCAP_TYPE) < 0)