netdev - Re: [PATCH] net: ftgmac100: Fix crash when removing driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201112152241.7a3acaca@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 15:22:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joel Stanley <joel@....id.au>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Andrew Jeffery <andrew@...id.au>,
        Ivan Mikhaylov <i.mikhaylov@...ro.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ftgmac100: Fix crash when removing driver

On Thu, 12 Nov 2020 11:01:45 +1030 Joel Stanley wrote:
> When removing the driver we would hit BUG_ON(!list_empty(&dev->ptype_specific))
> in net/core/dev.c due to still having the NC-SI packet handler
> registered.

> Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode")
> Signed-off-by: Joel Stanley <joel@....id.au>

Thanks for the fix, I think there is another one of those missing in 
the error path of ftgmac100_probe(), right?  Under err_ncsi_dev?