netdev - Re: [PATCH net-next] net/mlx5: Fix passing zero to 'PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06f889297f97217961e4e563d2715f28d1e8d953.camel@kernel.org>
Date:   Thu, 12 Nov 2020 15:58:10 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>, leon@...nel.org,
        davem@...emloft.net, kuba@...nel.org, vuhuong@...lanox.com
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR'

On Thu, 2020-11-12 at 22:28 +0800, YueHaibing wrote:
> Fix smatch warnings:
> 
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c:105
> esw_acl_egress_lgcy_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c:177
> esw_acl_egress_ofld_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c:184
> esw_acl_ingress_lgcy_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c:262
> esw_acl_ingress_ofld_setup() warn: passing zero to 'PTR_ERR'
> 
> esw_acl_table_create() never returns NULL, so
> NULL test should be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 

Applied to net-next-mlx5 

thanks