netdev - RE: [EXT] Re: [PATCH v9,net-next,05/12] crypto: octeontx2: add mailbox communication with AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR18MB2791873F6D23CC618AD76093A0E70@BYAPR18MB2791.namprd18.prod.outlook.com>
Date:   Thu, 12 Nov 2020 07:07:34 +0000
From:   Srujana Challa <schalla@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Suheil Chandran <schandran@...vell.com>,
        "Narayana Prasad Raju Athreya" <pathreya@...vell.com>,
        "Lukas Bartosik [C]" <lbartosik@...vell.com>
Subject: RE: [EXT] Re: [PATCH v9,net-next,05/12] crypto: octeontx2: add
 mailbox communication with AF

> On Mon, 9 Nov 2020 17:39:17 +0530 Srujana Challa wrote:
> > +	err = pci_alloc_irq_vectors(pdev, RVU_PF_INT_VEC_CNT,
> > +				    RVU_PF_INT_VEC_CNT, PCI_IRQ_MSIX);
> 
> I don't see any pci_free_irq_vectors() in this patch

This will be handled by the devres managed PCI interface.

Copied code for reference:

static void pcim_release(struct device *gendev, void *res)
{
    struct pci_dev *dev = to_pci_dev(gendev);
    struct pci_devres *this = res;
    int i;

    if (dev->msi_enabled)
        pci_disable_msi(dev);
    if (dev->msix_enabled)
        pci_disable_msix(dev);

    ....
}