netdev - Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 13 Nov 2020 17:23:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andrea Mayer <andrea.mayer@...roma2.it>,
        "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Shrijeet Mukherjee <shrijeet@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        netdev@...r.kernel.org
Subject: Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

Hi Andrea,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ipvs/master]
[also build test ERROR on linus/master sparc-next/master v5.10-rc3 next-20201112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andrea-Mayer/seg6-add-support-for-the-SRv6-End-DT4-behavior/20201109-093019
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: x86_64-randconfig-a005-20201111 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 874b0a0b9db93f5d3350ffe6b5efda2d908415d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/761138e2f757ac64efe97b03311c976db242dc92
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrea-Mayer/seg6-add-support-for-the-SRv6-End-DT4-behavior/20201109-093019
        git checkout 761138e2f757ac64efe97b03311c976db242dc92
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/ipv6/seg6_local.c:793:4: error: field designator 'slwt_ops' does not refer to any field in type 'struct seg6_action_desc'
                   .slwt_ops       = {
                    ^
>> net/ipv6/seg6_local.c:826:10: error: invalid application of 'sizeof' to an incomplete type 'struct seg6_action_desc []'
           count = ARRAY_SIZE(seg6_action_table);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/kernel.h:48:32: note: expanded from macro 'ARRAY_SIZE'
   #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                  ^~~~~
   2 errors generated.

vim +793 net/ipv6/seg6_local.c

   757	
   758	static struct seg6_action_desc seg6_action_table[] = {
   759		{
   760			.action		= SEG6_LOCAL_ACTION_END,
   761			.attrs		= 0,
   762			.input		= input_action_end,
   763		},
   764		{
   765			.action		= SEG6_LOCAL_ACTION_END_X,
   766			.attrs		= (1 << SEG6_LOCAL_NH6),
   767			.input		= input_action_end_x,
   768		},
   769		{
   770			.action		= SEG6_LOCAL_ACTION_END_T,
   771			.attrs		= (1 << SEG6_LOCAL_TABLE),
   772			.input		= input_action_end_t,
   773		},
   774		{
   775			.action		= SEG6_LOCAL_ACTION_END_DX2,
   776			.attrs		= (1 << SEG6_LOCAL_OIF),
   777			.input		= input_action_end_dx2,
   778		},
   779		{
   780			.action		= SEG6_LOCAL_ACTION_END_DX6,
   781			.attrs		= (1 << SEG6_LOCAL_NH6),
   782			.input		= input_action_end_dx6,
   783		},
   784		{
   785			.action		= SEG6_LOCAL_ACTION_END_DX4,
   786			.attrs		= (1 << SEG6_LOCAL_NH4),
   787			.input		= input_action_end_dx4,
   788		},
   789		{
   790			.action		= SEG6_LOCAL_ACTION_END_DT4,
   791			.attrs		= (1 << SEG6_LOCAL_TABLE),
   792			.input		= input_action_end_dt4,
 > 793			.slwt_ops	= {
   794						.build_state = seg6_end_dt4_build,
   795					  },
   796		},
   797		{
   798			.action		= SEG6_LOCAL_ACTION_END_DT6,
   799			.attrs		= (1 << SEG6_LOCAL_TABLE),
   800			.input		= input_action_end_dt6,
   801		},
   802		{
   803			.action		= SEG6_LOCAL_ACTION_END_B6,
   804			.attrs		= (1 << SEG6_LOCAL_SRH),
   805			.input		= input_action_end_b6,
   806		},
   807		{
   808			.action		= SEG6_LOCAL_ACTION_END_B6_ENCAP,
   809			.attrs		= (1 << SEG6_LOCAL_SRH),
   810			.input		= input_action_end_b6_encap,
   811			.static_headroom	= sizeof(struct ipv6hdr),
   812		},
   813		{
   814			.action		= SEG6_LOCAL_ACTION_END_BPF,
   815			.attrs		= (1 << SEG6_LOCAL_BPF),
   816			.input		= input_action_end_bpf,
   817		},
   818	
   819	};
   820	
   821	static struct seg6_action_desc *__get_action_desc(int action)
   822	{
   823		struct seg6_action_desc *desc;
   824		int i, count;
   825	
 > 826		count = ARRAY_SIZE(seg6_action_table);
   827		for (i = 0; i < count; i++) {
   828			desc = &seg6_action_table[i];
   829			if (desc->action == action)
   830				return desc;
   831		}
   832	
   833		return NULL;
   834	}
   835	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35348 bytes)