netdev - Re: [PATCH net-next 0/3] sfc: further EF100 encap TSO features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UfrqzSv7DSsQby1jRZGNLYDHURLpK7qt8PFRpCEM=8+Dg@mail.gmail.com>
Date:   Fri, 13 Nov 2020 11:09:26 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Edward Cree <ecree@...arflare.com>
Cc:     Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/3] sfc: further EF100 encap TSO features

On Thu, Nov 12, 2020 at 7:19 AM Edward Cree <ecree@...arflare.com> wrote:
>
> This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as
>  well as improving the handling of UDP tunnel TSO.
>
> Edward Cree (3):
>   sfc: extend bitfield macros to 19 fields
>   sfc: correctly support non-partial GSO_UDP_TUNNEL_CSUM on EF100
>   sfc: support GRE TSO on EF100
>
>  drivers/net/ethernet/sfc/bitfield.h  | 26 +++++++++++++++++++++-----
>  drivers/net/ethernet/sfc/ef100_nic.c |  8 ++++++--
>  drivers/net/ethernet/sfc/ef100_tx.c  | 12 ++++++++++--
>  3 files changed, 37 insertions(+), 9 deletions(-)
>

The code itself is mostly solid. The only issue I see is a question I
have about if we really need to be defining so many of the
"EFX_POPULATE_..." macros in patch 1 as it seems a bit gratuitous and
could likely be replaced by just adding multiple dummy fields to a
single macro instead of defining multiple macros to get to the end
goal.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>