netdev - Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112180041.1f1f96b9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 18:00:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Zhang Changzhong <zhangchangzhong@...wei.com>, nbd@....name,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        "David S . Miller" <davem@...emloft.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code
 in mtk_star_enable()

On Thu, 12 Nov 2020 12:41:26 +0100 Bartosz Golaszewski wrote:
> On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
> <zhangchangzhong@...wei.com> wrote:
> >
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> 
> Acked-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Applied, thanks!