netdev - Re: [PATCH net] net: dsa: lantiq_gswip: add missed clk_disable_unprepare() in gswip_gphy_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 10:34:43 +0800
From:   Zhang Changzhong <zhangchangzhong@...wei.com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     <hauke@...ke-m.de>, <andrew@...n.ch>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <davem@...emloft.net>, <kuba@...nel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: lantiq_gswip: add missed
 clk_disable_unprepare() in gswip_gphy_fw_load()

On 2020/11/12 20:41, Vladimir Oltean wrote:
> 
> gswip_gphy_fw_list
> -> gswip_gphy_fw_probe
>    -> gswip_gphy_fw_load
>       -> clk_prepare_enable
>       -> then fails
> 
> Then gswip_gphy_fw_list does this:
> 	for_each_available_child_of_node(gphy_fw_list_np, gphy_fw_np) {
> 		err = gswip_gphy_fw_probe(priv, &priv->gphy_fw[i],
> 					  gphy_fw_np, i);
> 		if (err)
> 			goto remove_gphy;
> 		i++;
> 	}
> 
> 	return 0;
> 
> remove_gphy:
> 	for (i = 0; i < priv->num_gphy_fw; i++)
> 		gswip_gphy_fw_remove(priv, &priv->gphy_fw[i]);
> 
> 
> Then gswip_gphy_fw_remove does this:
> gswip_gphy_fw_remove
> -> clk_disable_unprepare
> 
> What's wrong with this?
> .
> 
Thanks for reminding, I got it wrong.