netdev - Re: [PATCH v3 net-next 07/13] octeontx2-af: Add debugfs entry to dump the MCAM rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB321287B069E8AC8147B2162CA2E50@DM6PR18MB3212.namprd18.prod.outlook.com>
Date:   Sat, 14 Nov 2020 18:57:43 +0000
From:   Naveen Mamindlapalli <naveenm@...vell.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "Linu Cherian" <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>
Subject: Re: [PATCH v3 net-next 07/13] octeontx2-af: Add debugfs entry to dump
 the MCAM rules

Hi Saeed,

> -----Original Message-----
> From: Saeed Mahameed <saeed@...nel.org>
> Sent: Friday, November 13, 2020 1:18 AM
> To: Naveen Mamindlapalli <naveenm@...vell.com>; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Cc: kuba@...nel.org; davem@...emloft.net; Sunil Kovvuri Goutham
> <sgoutham@...vell.com>; Linu Cherian <lcherian@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; Jerin Jacob Kollanukkaran
> <jerinj@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
> Hariprasad Kelam <hkelam@...vell.com>
> Subject: Re: [PATCH v3 net-next 07/13] octeontx2-af: Add debugfs entry
> to dump the MCAM rules
> 
> On Wed, 2020-11-11 at 12:43 +0530, Naveen Mamindlapalli wrote:
> > From: Subbaraya Sundeep <sbhatta@...vell.com>
> >
> > Add debugfs support to dump the MCAM rules installed using
> > NPC_INSTALL_FLOW mbox message. Debugfs file can display mcam entry,
> > counter if any, flow type and counter hits.
> >
> > Ethtool will dump the ntuple flows related to the PF only.
> > The debugfs file gives systemwide view of the MCAM rules installed by
> > all the PF's.
> >
> > Below is the example output when the debugfs file is read:
> > ~ # mount -t debugfs none /sys/kernel/debug ~ # cat
> > /sys/kernel/debug/octeontx2/npc/mcam_rules
> >
> > 	Installed by: PF1
> > 	direction: RX
> >         mcam entry: 227
> > 	udp source port 23 mask 0xffff
> > 	Forward to: PF1 VF0
> >         action: Direct to queue 0
> > 	enabled: yes
> >         counter: 1
> >         hits: 0
> >
> 
> I don't want to block this series or anything, but you might want to use devlink
> dpipe interface for this:
> 
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.kernel.org_doc_html_latest_networking_devlink_devlink-
> 2Ddpipe.html&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=TwreqwV6mQ8K9
> wIpqwFO8yjikO_w1jUOe2MzChg4Rmg&m=Q3bIaVBAvCHGU817Tap8T9ooBFRP
> CJhP9kvFODtUnJg&s=YV7Q2w0JHxg9RUdwJvMfjC063Umev9Hpb6YvNSbe37A&e
> =
> 
> As a future patch of course.

Thanks for the pointers. We will definitely look into adding the devlink dpipe support in future.

> 
> Thanks,
> Saeed.